Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add fix to change the no_device parameter value to string #386

Merged
merged 4 commits into from
Jun 15, 2021
Merged

Add fix to change the no_device parameter value to string #386

merged 4 commits into from
Jun 15, 2021

Conversation

srirachanaachyuthuni
Copy link
Contributor

SUMMARY

Changes the value of no_device parameter from Bool to String for Boto3

Fixes: #120

ISSUE TYPE
COMPONENT NAME

ec2_ami

ADDITIONAL INFORMATION

@ansibullbot
Copy link

cc @Constantin07 @gunzy83 @jillr @s-hertel @scicoin-project @tremble @wilvk @wimnat
click here for bot help

@ansibullbot ansibullbot added bug This issue/PR relates to a bug community_review integration tests/integration module module needs_triage plugins plugin (any type) tests tests labels Jun 14, 2021
@srirachanaachyuthuni srirachanaachyuthuni changed the title Add fix to change the no_device parameter value to string WIP: Add fix to change the no_device parameter value to string Jun 14, 2021
@ansibullbot ansibullbot added the WIP Work in progress label Jun 14, 2021
jillr
jillr reviewed Jun 14, 2021
View reviewed changes
Copy link
Collaborator

@jillr jillr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiny nit, otherwise this is looking pretty good - thanks @srirachanaachyuthuni!

plugins/modules/ec2_ami.py Show resolved Hide resolved
@jillr jillr requested a review from abikouo June 14, 2021 19:17
@jillr
Copy link
Collaborator

jillr commented Jun 14, 2021

@abikouo Could you give this PR a review when you have a chance please?

abikouo
abikouo approved these changes Jun 15, 2021
View reviewed changes
Copy link
Contributor

@abikouo abikouo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Great job!!

@srirachanaachyuthuni srirachanaachyuthuni changed the title WIP: Add fix to change the no_device parameter value to string Add fix to change the no_device parameter value to string Jun 15, 2021
@ansibullbot ansibullbot removed the WIP Work in progress label Jun 15, 2021
@jillr jillr added the gate label Jun 15, 2021
@ansible-zuul ansible-zuul bot merged commit dbec0b0 into ansible-collections:main Jun 15, 2021
@srirachanaachyuthuni srirachanaachyuthuni deleted the 120_ec2_ami_no_device branch June 16, 2021 13:44
2d6 pushed a commit to 2d6/amazon.aws that referenced this pull request Jun 19, 2021
@srirachanaachyuthuni @2d6
Add fix to change the no_device parameter value to string (ansible-co…
39e815b 
…llections#386)

Add fix to change the no_device parameter value to string

Reviewed-by: https://github.com/apps/ansible-zuul
goneri pushed a commit to goneri/amazon.aws that referenced this pull request Jun 25, 2021
@alinabuzachis @goneri
ec2_vpc_igw: increase integration tests coverage and code cleaning (a…
ddaaa67 
…nsible-collections#386)

* Internet gateway: add missing integration tests and code check
 * Add CamelCase tags integration test
 * Removed check_input_tags() because useless as ansible_dict_to_boto3_tag_list() already performs a to_native() conversion to strings
 * Add additional integration tests for ec2_vpc_igw_info module

Signed-off-by: Alina Buzachis <[email protected]>

* Internet Gateway - integration tests
 * Fix Internet Gatways search by tags

* * Apply reviewer suggestions
        * Better error handling for the waiter

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@f7a818b
alinabuzachis added a commit to alinabuzachis/amazon.aws that referenced this pull request Jul 19, 2021
@alinabuzachis
ec2_vpc_igw: increase integration tests coverage and code cleaning (a…
c5ff32b 
…nsible-collections#386)

* Internet gateway: add missing integration tests and code check
 * Add CamelCase tags integration test
 * Removed check_input_tags() because useless as ansible_dict_to_boto3_tag_list() already performs a to_native() conversion to strings
 * Add additional integration tests for ec2_vpc_igw_info module

Signed-off-by: Alina Buzachis <[email protected]>

* Internet Gateway - integration tests
 * Fix Internet Gatways search by tags

* * Apply reviewer suggestions
        * Better error handling for the waiter

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@cff6d00
alinabuzachis added a commit to alinabuzachis/amazon.aws that referenced this pull request Jul 19, 2021
@alinabuzachis
ec2_vpc_igw: increase integration tests coverage and code cleaning (a…
08c098b 
…nsible-collections#386)

* Internet gateway: add missing integration tests and code check
 * Add CamelCase tags integration test
 * Removed check_input_tags() because useless as ansible_dict_to_boto3_tag_list() already performs a to_native() conversion to strings
 * Add additional integration tests for ec2_vpc_igw_info module

Signed-off-by: Alina Buzachis <[email protected]>

* Internet Gateway - integration tests
 * Fix Internet Gatways search by tags

* * Apply reviewer suggestions
        * Better error handling for the waiter

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@cff6d00
alinabuzachis added a commit to alinabuzachis/amazon.aws that referenced this pull request Jul 19, 2021
@alinabuzachis
ec2_vpc_igw: increase integration tests coverage and code cleaning (a…
5b6a6be 
…nsible-collections#386)

* Internet gateway: add missing integration tests and code check
 * Add CamelCase tags integration test
 * Removed check_input_tags() because useless as ansible_dict_to_boto3_tag_list() already performs a to_native() conversion to strings
 * Add additional integration tests for ec2_vpc_igw_info module

Signed-off-by: Alina Buzachis <[email protected]>

* Internet Gateway - integration tests
 * Fix Internet Gatways search by tags

* * Apply reviewer suggestions
        * Better error handling for the waiter

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@cff6d00
alinabuzachis added a commit to alinabuzachis/amazon.aws that referenced this pull request Jul 19, 2021
@alinabuzachis
ec2_vpc_igw: increase integration tests coverage and code cleaning (a…
1742d5b 
…nsible-collections#386)

* Internet gateway: add missing integration tests and code check
 * Add CamelCase tags integration test
 * Removed check_input_tags() because useless as ansible_dict_to_boto3_tag_list() already performs a to_native() conversion to strings
 * Add additional integration tests for ec2_vpc_igw_info module

Signed-off-by: Alina Buzachis <[email protected]>

* Internet Gateway - integration tests
 * Fix Internet Gatways search by tags

* * Apply reviewer suggestions
        * Better error handling for the waiter

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@cff6d00
alinabuzachis added a commit to alinabuzachis/amazon.aws that referenced this pull request Jul 19, 2021
@alinabuzachis
ec2_vpc_igw: increase integration tests coverage and code cleaning (a…
7bb3f22 
…nsible-collections#386)

* Internet gateway: add missing integration tests and code check
 * Add CamelCase tags integration test
 * Removed check_input_tags() because useless as ansible_dict_to_boto3_tag_list() already performs a to_native() conversion to strings
 * Add additional integration tests for ec2_vpc_igw_info module

Signed-off-by: Alina Buzachis <[email protected]>

* Internet Gateway - integration tests
 * Fix Internet Gatways search by tags

* * Apply reviewer suggestions
        * Better error handling for the waiter

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@cff6d00
alinabuzachis added a commit to alinabuzachis/amazon.aws that referenced this pull request Jul 19, 2021
@alinabuzachis
ec2_vpc_igw: increase integration tests coverage and code cleaning (a…
e258805 
…nsible-collections#386)

* Internet gateway: add missing integration tests and code check
 * Add CamelCase tags integration test
 * Removed check_input_tags() because useless as ansible_dict_to_boto3_tag_list() already performs a to_native() conversion to strings
 * Add additional integration tests for ec2_vpc_igw_info module

Signed-off-by: Alina Buzachis <[email protected]>

* Internet Gateway - integration tests
 * Fix Internet Gatways search by tags

* * Apply reviewer suggestions
        * Better error handling for the waiter

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@cff6d00
alinabuzachis added a commit to alinabuzachis/amazon.aws that referenced this pull request Jul 20, 2021
@alinabuzachis
ec2_vpc_igw: increase integration tests coverage and code cleaning (a…
9034d11 
…nsible-collections#386)

* Internet gateway: add missing integration tests and code check
 * Add CamelCase tags integration test
 * Removed check_input_tags() because useless as ansible_dict_to_boto3_tag_list() already performs a to_native() conversion to strings
 * Add additional integration tests for ec2_vpc_igw_info module

Signed-off-by: Alina Buzachis <[email protected]>

* Internet Gateway - integration tests
 * Fix Internet Gatways search by tags

* * Apply reviewer suggestions
        * Better error handling for the waiter

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@cff6d00
alinabuzachis added a commit to alinabuzachis/amazon.aws that referenced this pull request Jul 20, 2021
@alinabuzachis
ec2_vpc_igw: increase integration tests coverage and code cleaning (a…
fabeb50 
…nsible-collections#386)

* Internet gateway: add missing integration tests and code check
 * Add CamelCase tags integration test
 * Removed check_input_tags() because useless as ansible_dict_to_boto3_tag_list() already performs a to_native() conversion to strings
 * Add additional integration tests for ec2_vpc_igw_info module

Signed-off-by: Alina Buzachis <[email protected]>

* Internet Gateway - integration tests
 * Fix Internet Gatways search by tags

* * Apply reviewer suggestions
        * Better error handling for the waiter

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@cff6d00
alinabuzachis added a commit to alinabuzachis/amazon.aws that referenced this pull request Jul 20, 2021
@alinabuzachis
ec2_vpc_igw: increase integration tests coverage and code cleaning (a…
1cf45cb 
…nsible-collections#386)

* Internet gateway: add missing integration tests and code check
 * Add CamelCase tags integration test
 * Removed check_input_tags() because useless as ansible_dict_to_boto3_tag_list() already performs a to_native() conversion to strings
 * Add additional integration tests for ec2_vpc_igw_info module

Signed-off-by: Alina Buzachis <[email protected]>

* Internet Gateway - integration tests
 * Fix Internet Gatways search by tags

* * Apply reviewer suggestions
        * Better error handling for the waiter

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@cff6d00
alinabuzachis added a commit to alinabuzachis/amazon.aws that referenced this pull request Jul 20, 2021
@alinabuzachis
ec2_vpc_igw: increase integration tests coverage and code cleaning (a…
fc22a80 
…nsible-collections#386)

* Internet gateway: add missing integration tests and code check
 * Add CamelCase tags integration test
 * Removed check_input_tags() because useless as ansible_dict_to_boto3_tag_list() already performs a to_native() conversion to strings
 * Add additional integration tests for ec2_vpc_igw_info module

Signed-off-by: Alina Buzachis <[email protected]>

* Internet Gateway - integration tests
 * Fix Internet Gatways search by tags

* * Apply reviewer suggestions
        * Better error handling for the waiter

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@cff6d00
alinabuzachis added a commit to alinabuzachis/amazon.aws that referenced this pull request Jul 20, 2021
@alinabuzachis
ec2_vpc_igw: increase integration tests coverage and code cleaning (a…
096be48 
…nsible-collections#386)

* Internet gateway: add missing integration tests and code check
 * Add CamelCase tags integration test
 * Removed check_input_tags() because useless as ansible_dict_to_boto3_tag_list() already performs a to_native() conversion to strings
 * Add additional integration tests for ec2_vpc_igw_info module

Signed-off-by: Alina Buzachis <[email protected]>

* Internet Gateway - integration tests
 * Fix Internet Gatways search by tags

* * Apply reviewer suggestions
        * Better error handling for the waiter

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@cff6d00
alinabuzachis added a commit to alinabuzachis/amazon.aws that referenced this pull request Jul 20, 2021
@alinabuzachis
ec2_vpc_igw: increase integration tests coverage and code cleaning (a…
6c6ce1a 
…nsible-collections#386)

* Internet gateway: add missing integration tests and code check
 * Add CamelCase tags integration test
 * Removed check_input_tags() because useless as ansible_dict_to_boto3_tag_list() already performs a to_native() conversion to strings
 * Add additional integration tests for ec2_vpc_igw_info module

Signed-off-by: Alina Buzachis <[email protected]>

* Internet Gateway - integration tests
 * Fix Internet Gatways search by tags

* * Apply reviewer suggestions
        * Better error handling for the waiter

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@cff6d00
alinabuzachis added a commit to alinabuzachis/amazon.aws that referenced this pull request Jul 20, 2021
@alinabuzachis
ec2_vpc_igw: increase integration tests coverage and code cleaning (a…
9d5aeff 
…nsible-collections#386)

* Internet gateway: add missing integration tests and code check
 * Add CamelCase tags integration test
 * Removed check_input_tags() because useless as ansible_dict_to_boto3_tag_list() already performs a to_native() conversion to strings
 * Add additional integration tests for ec2_vpc_igw_info module

Signed-off-by: Alina Buzachis <[email protected]>

* Internet Gateway - integration tests
 * Fix Internet Gatways search by tags

* * Apply reviewer suggestions
        * Better error handling for the waiter

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@cff6d00
alinabuzachis added a commit to alinabuzachis/amazon.aws that referenced this pull request Jul 20, 2021
@alinabuzachis
ec2_vpc_igw: increase integration tests coverage and code cleaning (a…
0857f30 
…nsible-collections#386)

* Internet gateway: add missing integration tests and code check
 * Add CamelCase tags integration test
 * Removed check_input_tags() because useless as ansible_dict_to_boto3_tag_list() already performs a to_native() conversion to strings
 * Add additional integration tests for ec2_vpc_igw_info module

Signed-off-by: Alina Buzachis <[email protected]>

* Internet Gateway - integration tests
 * Fix Internet Gatways search by tags

* * Apply reviewer suggestions
        * Better error handling for the waiter

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@cff6d00
alinabuzachis added a commit to alinabuzachis/amazon.aws that referenced this pull request Jul 20, 2021
@alinabuzachis
ec2_vpc_igw: increase integration tests coverage and code cleaning (a…
06c8e1b 
…nsible-collections#386)

* Internet gateway: add missing integration tests and code check
 * Add CamelCase tags integration test
 * Removed check_input_tags() because useless as ansible_dict_to_boto3_tag_list() already performs a to_native() conversion to strings
 * Add additional integration tests for ec2_vpc_igw_info module

Signed-off-by: Alina Buzachis <[email protected]>

* Internet Gateway - integration tests
 * Fix Internet Gatways search by tags

* * Apply reviewer suggestions
        * Better error handling for the waiter

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@cff6d00
alinabuzachis added a commit to alinabuzachis/amazon.aws that referenced this pull request Jul 20, 2021
@alinabuzachis
ec2_vpc_igw: increase integration tests coverage and code cleaning (a…
f4a5bde 
…nsible-collections#386)

* Internet gateway: add missing integration tests and code check
 * Add CamelCase tags integration test
 * Removed check_input_tags() because useless as ansible_dict_to_boto3_tag_list() already performs a to_native() conversion to strings
 * Add additional integration tests for ec2_vpc_igw_info module

Signed-off-by: Alina Buzachis <[email protected]>

* Internet Gateway - integration tests
 * Fix Internet Gatways search by tags

* * Apply reviewer suggestions
        * Better error handling for the waiter

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@cff6d00
alinabuzachis added a commit to alinabuzachis/amazon.aws that referenced this pull request Jul 20, 2021
@alinabuzachis
ec2_vpc_igw: increase integration tests coverage and code cleaning (a…
76e51b1 
…nsible-collections#386)

* Internet gateway: add missing integration tests and code check
 * Add CamelCase tags integration test
 * Removed check_input_tags() because useless as ansible_dict_to_boto3_tag_list() already performs a to_native() conversion to strings
 * Add additional integration tests for ec2_vpc_igw_info module

Signed-off-by: Alina Buzachis <[email protected]>

* Internet Gateway - integration tests
 * Fix Internet Gatways search by tags

* * Apply reviewer suggestions
        * Better error handling for the waiter

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@cff6d00
alinabuzachis added a commit to alinabuzachis/amazon.aws that referenced this pull request Jul 20, 2021
@alinabuzachis
ec2_vpc_igw: increase integration tests coverage and code cleaning (a…
8e2a079 
…nsible-collections#386)

* Internet gateway: add missing integration tests and code check
 * Add CamelCase tags integration test
 * Removed check_input_tags() because useless as ansible_dict_to_boto3_tag_list() already performs a to_native() conversion to strings
 * Add additional integration tests for ec2_vpc_igw_info module

Signed-off-by: Alina Buzachis <[email protected]>

* Internet Gateway - integration tests
 * Fix Internet Gatways search by tags

* * Apply reviewer suggestions
        * Better error handling for the waiter

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@cff6d00
alinabuzachis added a commit to alinabuzachis/amazon.aws that referenced this pull request Jul 20, 2021
@alinabuzachis
ec2_vpc_igw: increase integration tests coverage and code cleaning (a…
1e19785 
…nsible-collections#386)

* Internet gateway: add missing integration tests and code check
 * Add CamelCase tags integration test
 * Removed check_input_tags() because useless as ansible_dict_to_boto3_tag_list() already performs a to_native() conversion to strings
 * Add additional integration tests for ec2_vpc_igw_info module

Signed-off-by: Alina Buzachis <[email protected]>

* Internet Gateway - integration tests
 * Fix Internet Gatways search by tags

* * Apply reviewer suggestions
        * Better error handling for the waiter

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@cff6d00
alinabuzachis added a commit to alinabuzachis/amazon.aws that referenced this pull request Jul 20, 2021
@alinabuzachis
ec2_vpc_igw: increase integration tests coverage and code cleaning (a…
e02b30e 
…nsible-collections#386)

* Internet gateway: add missing integration tests and code check
 * Add CamelCase tags integration test
 * Removed check_input_tags() because useless as ansible_dict_to_boto3_tag_list() already performs a to_native() conversion to strings
 * Add additional integration tests for ec2_vpc_igw_info module

Signed-off-by: Alina Buzachis <[email protected]>

* Internet Gateway - integration tests
 * Fix Internet Gatways search by tags

* * Apply reviewer suggestions
        * Better error handling for the waiter

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@cff6d00
alinabuzachis added a commit to alinabuzachis/amazon.aws that referenced this pull request Jul 20, 2021
@alinabuzachis
ec2_vpc_igw: increase integration tests coverage and code cleaning (a…
5018085 
…nsible-collections#386)

* Internet gateway: add missing integration tests and code check
 * Add CamelCase tags integration test
 * Removed check_input_tags() because useless as ansible_dict_to_boto3_tag_list() already performs a to_native() conversion to strings
 * Add additional integration tests for ec2_vpc_igw_info module

Signed-off-by: Alina Buzachis <[email protected]>

* Internet Gateway - integration tests
 * Fix Internet Gatways search by tags

* * Apply reviewer suggestions
        * Better error handling for the waiter

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@cff6d00
alinabuzachis added a commit to alinabuzachis/amazon.aws that referenced this pull request Jul 20, 2021
@alinabuzachis
ec2_vpc_igw: increase integration tests coverage and code cleaning (a…
c850f8d 
…nsible-collections#386)

* Internet gateway: add missing integration tests and code check
 * Add CamelCase tags integration test
 * Removed check_input_tags() because useless as ansible_dict_to_boto3_tag_list() already performs a to_native() conversion to strings
 * Add additional integration tests for ec2_vpc_igw_info module

Signed-off-by: Alina Buzachis <[email protected]>

* Internet Gateway - integration tests
 * Fix Internet Gatways search by tags

* * Apply reviewer suggestions
        * Better error handling for the waiter

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@cff6d00
alinabuzachis added a commit to alinabuzachis/amazon.aws that referenced this pull request Jul 20, 2021
@alinabuzachis
ec2_vpc_igw: increase integration tests coverage and code cleaning (a…
994b0b3 
…nsible-collections#386)

* Internet gateway: add missing integration tests and code check
 * Add CamelCase tags integration test
 * Removed check_input_tags() because useless as ansible_dict_to_boto3_tag_list() already performs a to_native() conversion to strings
 * Add additional integration tests for ec2_vpc_igw_info module

Signed-off-by: Alina Buzachis <[email protected]>

* Internet Gateway - integration tests
 * Fix Internet Gatways search by tags

* * Apply reviewer suggestions
        * Better error handling for the waiter

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@cff6d00
alinabuzachis added a commit to alinabuzachis/amazon.aws that referenced this pull request Jul 20, 2021
@alinabuzachis
ec2_vpc_igw: increase integration tests coverage and code cleaning (a…
e3e36b0 
…nsible-collections#386)

* Internet gateway: add missing integration tests and code check
 * Add CamelCase tags integration test
 * Removed check_input_tags() because useless as ansible_dict_to_boto3_tag_list() already performs a to_native() conversion to strings
 * Add additional integration tests for ec2_vpc_igw_info module

Signed-off-by: Alina Buzachis <[email protected]>

* Internet Gateway - integration tests
 * Fix Internet Gatways search by tags

* * Apply reviewer suggestions
        * Better error handling for the waiter

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@cff6d00
jillr pushed a commit to jillr/amazon.aws that referenced this pull request Jul 27, 2021
@alinabuzachis @jillr
ec2_vpc_igw: increase integration tests coverage and code cleaning (a…
e2d668c 
…nsible-collections#386)

* Internet gateway: add missing integration tests and code check
 * Add CamelCase tags integration test
 * Removed check_input_tags() because useless as ansible_dict_to_boto3_tag_list() already performs a to_native() conversion to strings
 * Add additional integration tests for ec2_vpc_igw_info module

Signed-off-by: Alina Buzachis <[email protected]>

* Internet Gateway - integration tests
 * Fix Internet Gatways search by tags

* * Apply reviewer suggestions
        * Better error handling for the waiter

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@cff6d00
jillr pushed a commit to jillr/amazon.aws that referenced this pull request Aug 20, 2021
@alinabuzachis @jillr
ec2_vpc_igw: increase integration tests coverage and code cleaning (a…
e6027b1 
…nsible-collections#386)

* Internet gateway: add missing integration tests and code check
 * Add CamelCase tags integration test
 * Removed check_input_tags() because useless as ansible_dict_to_boto3_tag_list() already performs a to_native() conversion to strings
 * Add additional integration tests for ec2_vpc_igw_info module

Signed-off-by: Alina Buzachis <[email protected]>

* Internet Gateway - integration tests
 * Fix Internet Gatways search by tags

* * Apply reviewer suggestions
        * Better error handling for the waiter

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@cff6d00
jillr pushed a commit to jillr/amazon.aws that referenced this pull request Aug 26, 2021
@alinabuzachis @jillr
ec2_vpc_igw: increase integration tests coverage and code cleaning (a…
4b8c406 
…nsible-collections#386)

* Internet gateway: add missing integration tests and code check
 * Add CamelCase tags integration test
 * Removed check_input_tags() because useless as ansible_dict_to_boto3_tag_list() already performs a to_native() conversion to strings
 * Add additional integration tests for ec2_vpc_igw_info module

Signed-off-by: Alina Buzachis <[email protected]>

* Internet Gateway - integration tests
 * Fix Internet Gatways search by tags

* * Apply reviewer suggestions
        * Better error handling for the waiter

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@cff6d00
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Sep 18, 2023
@alinabuzachis
ec2_vpc_igw: increase integration tests coverage and code cleaning (a…
3fa8dd9 
…nsible-collections#386)

* Internet gateway: add missing integration tests and code check
 * Add CamelCase tags integration test
 * Removed check_input_tags() because useless as ansible_dict_to_boto3_tag_list() already performs a to_native() conversion to strings
 * Add additional integration tests for ec2_vpc_igw_info module

Signed-off-by: Alina Buzachis <[email protected]>

* Internet Gateway - integration tests
 * Fix Internet Gatways search by tags

* * Apply reviewer suggestions
        * Better error handling for the waiter
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Sep 18, 2023
@alinabuzachis @abikouo
ec2_vpc_igw: increase integration tests coverage and code cleaning (a…
6121c2a 
…nsible-collections#386)

* Internet gateway: add missing integration tests and code check
 * Add CamelCase tags integration test
 * Removed check_input_tags() because useless as ansible_dict_to_boto3_tag_list() already performs a to_native() conversion to strings
 * Add additional integration tests for ec2_vpc_igw_info module

Signed-off-by: Alina Buzachis <[email protected]>

* Internet Gateway - integration tests
 * Fix Internet Gatways search by tags

* * Apply reviewer suggestions
        * Better error handling for the waiter
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Oct 24, 2023
@alinabuzachis
ec2_vpc_igw: increase integration tests coverage and code cleaning (a…
cff6d00 
…nsible-collections#386)

* Internet gateway: add missing integration tests and code check
 * Add CamelCase tags integration test
 * Removed check_input_tags() because useless as ansible_dict_to_boto3_tag_list() already performs a to_native() conversion to strings
 * Add additional integration tests for ec2_vpc_igw_info module

Signed-off-by: Alina Buzachis <[email protected]>

* Internet Gateway - integration tests
 * Fix Internet Gatways search by tags

* * Apply reviewer suggestions
        * Better error handling for the waiter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abikouo abikouo abikouo approved these changes

@jillr jillr jillr approved these changes

Assignees
No one assigned
Labels
bug This issue/PR relates to a bug community_review integration tests/integration module module plugins plugin (any type) tests tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Type error on no_device parameter of ec2_ami module
4 participants
@srirachanaachyuthuni @ansibullbot @jillr @abikouo